[GitHub] [spark] cxzl25 commented on a diff in pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name

Wed, 20 Apr 2022 09:05:50 -0700 


cxzl25 commented on code in PR #36245:
URL: https://github.com/apache/spark/pull/36245#discussion_r854313221


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala:
##########
@@ -262,7 +262,8 @@ trait BaseScriptTransformationExec extends UnaryExecNode {
       }
 }
 
-abstract class BaseScriptTransformationWriterThread extends Thread with 
Logging {
+abstract class BaseScriptTransformationWriterThread
+  extends Thread("Thread-ScriptTransformation-Feed") with Logging {

Review Comment:
   We can follow a format like this.
   
https://github.com/apache/spark/blob/8acce8885964fcb5b23046bdac8a882d723f35cc/sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala#L100
   
   
![image](https://user-images.githubusercontent.com/3898450/164274148-e3097a81-4a76-4d24-85f3-0b8ec5822f81.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to