mridulm commented on code in PR #36293:
URL: https://github.com/apache/spark/pull/36293#discussion_r854758572
##########
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala:
##########
@@ -3742,7 +3742,8 @@ class DAGSchedulerSuite extends SparkFunSuite with
TempLocalSparkContext with Ti
runEvent(StageCancelled(0, Option("Explicit cancel check")))
scheduler.handleShuffleMergeFinalized(shuffleMapStageToCancel,
shuffleMapStageToCancel.shuffleDep.shuffleMergeId)
- assert(mapOutputTracker.getNumAvailableMergeResults(shuffleDep.shuffleId)
== 0)
+ assert(mapOutputTracker.getNumAvailableMergeResults(shuffleDep.shuffleId)
== 2)
+ assert(shuffleMapStageToCancel.shuffleDep.isShuffleMergeFinalizedMarked)
Review Comment:
For indeterminate stages, we expect it to be unregistered (for same
shuffleMergeId), right ?
##########
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala:
##########
@@ -3742,7 +3742,8 @@ class DAGSchedulerSuite extends SparkFunSuite with
TempLocalSparkContext with Ti
runEvent(StageCancelled(0, Option("Explicit cancel check")))
scheduler.handleShuffleMergeFinalized(shuffleMapStageToCancel,
shuffleMapStageToCancel.shuffleDep.shuffleMergeId)
- assert(mapOutputTracker.getNumAvailableMergeResults(shuffleDep.shuffleId)
== 0)
+ assert(mapOutputTracker.getNumAvailableMergeResults(shuffleDep.shuffleId)
== 2)
+ assert(shuffleMapStageToCancel.shuffleDep.isShuffleMergeFinalizedMarked)
Review Comment:
For indeterminate stages, we expect it to be unregistered (for same
shuffleMergeId), right ?
Add a test for that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
