otterc commented on code in PR #36305:
URL: https://github.com/apache/spark/pull/36305#discussion_r855455678
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -1166,6 +1166,8 @@ final class ShuffleBlockFetcherIterator(
case ShuffleBlockBatchId(shuffleId, mapId, startReduceId, _) =>
throw SparkCoreErrors.fetchFailedError(address, shuffleId, mapId,
mapIndex, startReduceId,
msg, e)
+ case ShuffleBlockChunkId(_, _, _, _) =>
+ pushBasedFetchHelper.initiateFallbackFetchForPushMergedBlock(blockId,
address)
Review Comment:
Wouldn't this result in duplicate records? Some of the chunk is already
consumed but we don't know how much is that correct? So now we fallback to
original blocks but and that could re-fetch the records that were already
consumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
