cloud-fan commented on code in PR #36230:
URL: https://github.com/apache/spark/pull/36230#discussion_r855731223
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala:
##########
@@ -144,8 +144,17 @@ object EliminateOuterJoin extends Rule[LogicalPlan] with
PredicateHelper {
val emptyRow = new GenericInternalRow(attributes.length)
val boundE = BindReferences.bindReference(e, attributes)
if (boundE.exists(_.isInstanceOf[Unevaluable])) return false
- val v = boundE.eval(emptyRow)
- v == null || v == false
+
+ // some expressions, like map(), may throw an exception when dealing with
null values.
+ // therefore, we need to handle exceptions.
+ try {
+ val v = boundE.eval(emptyRow)
+ v == null || v == false
+ } catch {
+ case e: Exception =>
Review Comment:
Let' follow the convention and catch `NonFatal(e)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
