xiuzhu9527 commented on PR #36217: URL: https://github.com/apache/spark/pull/36217#issuecomment-1107709852
> not > I see comments in the POM files like: > > ``` > <!-- > This spark-tags test-dep is needed even though it isn't used in this module, otherwise testing-cmds that exclude > them will yield errors. > --> > ``` > > It might be safe to remove, but does it harm anything? probably not worth special casing, and I'm not sure there's not an impact It hasn't done any harm yet, but I think it's not standardized, spark-tags-tests.jar should only appear in maven test phase, but it appears in spark release package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
