awdavidson commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r857708733
########## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ########## @@ -1954,6 +1954,22 @@ class Dataset[T] private[sql]( @scala.annotation.varargs def agg(expr: Column, exprs: Column*): DataFrame = groupBy().agg(expr, exprs : _*) + def melt(id: String, ids: String*) + (value: String, values: String*): DataFrame = + Melt.of(this, id +: ids, value +: values) + + def melt(dropNulls: Boolean, id: String, ids: String*) + (value: String, values: String*): DataFrame = + Melt.of(this, id +: ids, value +: values, dropNulls = dropNulls) + + def melt(variableColumnName: String, + valueColumnName: String, + dropNulls: Boolean, + expr: String, + exprs: String*)(id: String, ids: String*): DataFrame = Review Comment: nit: lets be consistent with argument names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
