minyyy commented on PR #36121: URL: https://github.com/apache/spark/pull/36121#issuecomment-1109142484
> `InferFiltersFromGenerate` is a newly added rule, does it mean we don't have this performance issue in old versions of Spark? The benchmark ran for tpc-ds queries. But the `PruneFilters` rule actually runs for all filters (its last branch is `case f @ Filter(fc, p: LogicalPlan)`). In some extreme cases where a query has lots of filters with complicated enough predicates that `canonicalized` costs significant amount of time, the optimization probably matters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
