LuciferYang commented on code in PR #36262:
URL: https://github.com/apache/spark/pull/36262#discussion_r858178029
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArraySuite.scala:
##########
@@ -56,7 +59,7 @@ class ExternalAppendOnlyUnsafeRowArraySuite extends
SparkFunSuite with LocalSpar
private def insertRow(array: ExternalAppendOnlyUnsafeRowArray): Long = {
val valueInserted = random.nextLong()
- val row = new UnsafeRow(1)
+ val row = new UnsafeRow( 1)
Review Comment:
done
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala:
##########
@@ -228,6 +234,11 @@ private[sql] class ExternalAppendOnlyUnsafeRowArray(
currentRow.pointTo(iterator.getBaseObject, iterator.getBaseOffset,
iterator.getRecordLength)
currentRow
}
+
+ override protected def closeIfNeed(): Unit = iterator match {
Review Comment:
[c8f6f08](https://github.com/apache/spark/pull/36262/commits/c8f6f0871f5875433d5dc951805a7e40d875b7ee)
fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
