peter-toth commented on code in PR #32298:
URL: https://github.com/apache/spark/pull/32298#discussion_r858356316
##########
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:
##########
@@ -264,28 +264,25 @@ class InjectRuntimeFilterSuite extends QueryTest with
SQLTestUtils with SharedSp
}
}
- def getNumBloomFilters(plan: LogicalPlan): Integer = {
- val numBloomFilterAggs = plan.collect {
- case Filter(condition, _) => condition.collect {
- case subquery: org.apache.spark.sql.catalyst.expressions.ScalarSubquery
- => subquery.plan.collect {
- case Aggregate(_, aggregateExpressions, _) =>
- aggregateExpressions.map {
- case Alias(AggregateExpression(bfAgg : BloomFilterAggregate, _,
_, _, _),
- _) =>
- assert(bfAgg.estimatedNumItemsExpression.isInstanceOf[Literal])
- assert(bfAgg.numBitsExpression.isInstanceOf[Literal])
- 1
- }.sum
+ // `MergeScalarSubqueries` can duplicate subqueries in the optimized plan,
but the subqueries will
+ // be reused in the physical plan.
+ def getNumBloomFilters(plan: LogicalPlan, scalarSubqueryCTEMultiplicator:
Int = 1): Integer = {
+ print(plan)
Review Comment:
ops, sorry. I will open a follow-up PR right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
