cloud-fan commented on code in PR #36325:
URL: https://github.com/apache/spark/pull/36325#discussion_r858772150
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/AggregatePushDownUtils.scala:
##########
@@ -106,11 +107,11 @@ object AggregatePushDownUtils {
// aggregate push down simple and don't handle this complicate case for
now.
return None
}
- aggregation.groupByColumns.foreach { col =>
+ aggregation.groupByExpressions.flatMap(extractColName).foreach { fieldName
=>
Review Comment:
We should return None earlier if any of the group by expr is not a column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
