gengliangwang commented on code in PR #36212:
URL: https://github.com/apache/spark/pull/36212#discussion_r858800256
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1090,13 +1117,11 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
}
// The configuration option to append missing NULL values to the end of
the INSERT INTO
// statement is not enabled.
- withSQLConf(SQLConf.USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES.key ->
"false") {
Review Comment:
Let's keep this `withSQLConf`, in case we change the default value in the
future release.
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1200,43 +1225,41 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
// When the USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES configuration is
disabled, and no
// explicit DEFAULT value is available when the INSERT INTO statement
provides fewer
// values than expected, the INSERT INTO command fails to execute.
- withSQLConf(SQLConf.USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES.key ->
"false") {
Review Comment:
Let's keep this `withSQLConf`, in case we change the default value in the
future release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
