peter-toth commented on code in PR #36361:
URL: https://github.com/apache/spark/pull/36361#discussion_r858892542
##########
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:
##########
@@ -267,14 +267,20 @@ class InjectRuntimeFilterSuite extends QueryTest with
SQLTestUtils with SharedSp
// `MergeScalarSubqueries` can duplicate subqueries in the optimized plan,
but the subqueries will
// be reused in the physical plan.
def getNumBloomFilters(plan: LogicalPlan, scalarSubqueryCTEMultiplicator:
Int = 1): Integer = {
- val numBloomFilterAggs = plan.collectWithSubqueries {
- case Aggregate(_, aggregateExpressions, _) =>
- aggregateExpressions.collect {
- case Alias(AggregateExpression(bfAgg: BloomFilterAggregate, _, _, _,
_), _) =>
- assert(bfAgg.estimatedNumItemsExpression.isInstanceOf[Literal])
- assert(bfAgg.numBitsExpression.isInstanceOf[Literal])
- 1
+ val numBloomFilterAggs = plan.collect {
+ case Filter(condition, _) => condition.collect {
+ case subquery: org.apache.spark.sql.catalyst.expressions.ScalarSubquery
Review Comment:
https://github.com/apache/spark/pull/36361/commits/7ac7981a3f9ded78744f76ce1e2b6f6564aae7bf
removes `scalarSubqueryCTEMultiplicator`,
https://github.com/apache/spark/pull/36361/commits/9b1347eafa9537ad216af95b2d321948f0bcd1b0
adds a new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
