dongjoon-hyun commented on code in PR #36368:
URL: https://github.com/apache/spark/pull/36368#discussion_r859361263
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala:
##########
@@ -102,7 +104,8 @@ object KubernetesUtils extends Logging {
val hadoopConf = SparkHadoopUtil.get.newConfiguration(conf)
val localFile = downloadFile(templateFileName, Utils.createTempDir(),
conf, hadoopConf)
val templateFile = new File(new java.net.URI(localFile).getPath)
- val pod = kubernetesClient.pods().load(templateFile).get()
+ val podTemplateString = Files.toString(templateFile,
StandardCharsets.UTF_8)
+ val pod = kubernetesClient.pods().load(podTemplateString).get()
Review Comment:
May I ask where is the placeholder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
