MaxGekk commented on code in PR #36350:
URL: https://github.com/apache/spark/pull/36350#discussion_r859601129
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -196,6 +196,9 @@
"UNSUPPORTED_OPERATION" : {
"message" : [ "The operation is not supported: <operation>" ]
},
+ "UNSUPPORTED_SAVE_MODE" : {
+ "message" : [ "The saveMode is not supported: <saveMode> (<pathExists>)" ]
Review Comment:
The message is not clear from user side, I believe. Let's introduce two
sub-classes EXISTENT_PATH and NON_EXISTENT_PATH. Messages should be something
like:
1. The save mode `<saveMode>` is not supported for: an existent path.
2. The save mode `<saveMode>` is not supported for: a not existent path.
What's does true or false in the error message mean is not clear from my
point of view.
See https://github.com/apache/spark/pull/36307 for an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
