cxzl25 commented on PR #36301: URL: https://github.com/apache/spark/pull/36301#issuecomment-1111033480
> The code refers to commons-logging, but we generally pipe through slf4j. Does this actually trigger the shim implementation in slf4j? Because the spark driver classpath uses jars/* to start, the api of commons logging sometimes uses `jcl-over-slf4j`, sometimes uses `commons-logging-1.1.3.jar` implementation, the latter in the case of using add hdfs jar there may be problems So if `jcl-over-slf4j` is loaded before `commons-logging-1.1.3.jar`, `org.apache.commons.logging.LogFactory.getFactory` is to call the implementation of `slf4j`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
