cloud-fan commented on code in PR #36332:
URL: https://github.com/apache/spark/pull/36332#discussion_r859958160


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/Predicate.java:
##########
@@ -146,4 +149,210 @@ public class Predicate extends GeneralScalarExpression {
   public Predicate(String name, Expression[] children) {
     super(name, children);
   }
+
+  public org.apache.spark.sql.sources.Filter toV1() {

Review Comment:
   We shouldn't add this public API. Can we have a private internal util 
function to do it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to