MaxGekk commented on code in PR #36385:
URL: https://github.com/apache/spark/pull/36385#discussion_r860941641
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -261,41 +261,45 @@ class QueryExecutionErrorsSuite
}
}
- test("UNSUPPORTED_OPERATION: timeZoneId not specified while converting
TimestampType to Arrow") {
+ test("UNSUPPORTED_FEATURE: timeZoneId not specified while converting
TimestampType to Arrow") {
checkErrorClass(
exception = intercept[SparkUnsupportedOperationException] {
ArrowUtils.toArrowSchema(new StructType().add("value", TimestampType),
null)
Review Comment:
Let's replace the check
https://github.com/apache/spark/blob/88e53e59e746a6d3aadac3cdc5fcbd74d90ee0e9/sql/catalyst/src/main/scala/org/apache/spark/sql/util/ArrowUtils.scala#L51
by an assert, and remove the test. `ArrowUtils.toArrowType()` is internal API,
BTW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
