dtenedor commented on code in PR #36398:
URL: https://github.com/apache/spark/pull/36398#discussion_r862996565


##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -976,13 +976,6 @@ class InsertSuite extends DataSourceTest with 
SharedSparkSession {
       sql("insert into t select false, default")
       checkAnswer(spark.table("t"), Row(false, 42L))
     }
-    // There is a complex query plan in the SELECT query in the INSERT INTO 
statement.
-    withTable("t") {
-      sql("create table t(i boolean default false, s bigint default 42) using 
parquet")
-      sql("insert into t select col, count(*) from values (default, default) " 
+

Review Comment:
   The test case updated since the set of allowed operators above the `INSERT 
INTO ... VALUES` list changed. But it is fine to keep this a pure refactoring 
PR, I added `Aggregate` to the allowed operators and now all the test are 
exactly the same now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to