sunchao commented on code in PR #35965:
URL: https://github.com/apache/spark/pull/35965#discussion_r863083877
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala:
##########
@@ -138,6 +138,12 @@ trait DataSourceV2ScanExecBase extends LeafExecNode {
}
}
+ override def outputOrdering: Seq[SortOrder] = scan match {
+ case s: SupportsReportOrdering if this.logicalLink.isDefined =>
Review Comment:
> Whoever calls into groupPartitions should consider ...
Yes, although `groupPartitions` is called by Spark right now so we should
update accordingly in this PR too. Otherwise, after this PR the
`outputOrdering` could be incorrect if grouping happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
