sunchao commented on PR #36202:
URL: https://github.com/apache/spark/pull/36202#issuecomment-1117565672
Thanks @dongjoon-hyun @viirya and @sadikovi ! I updated the PR a little bit
since in the following section:
```scala
} else if (!state.isRequired && currentValue ==
state.maxDefinitionLevel - 1) {
// Only add null if this represents a null element, but not
for the case where a
// struct itself is null
```
the comments and the condition check are out-dated and can be removed, even
though it doesn't affect correctness.
Will commit this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
