Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6139#discussion_r30362273
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -115,7 +118,7 @@ def get$Name(self):
("outputCol", "output column name", None),
("numFeatures", "number of features", None),
("checkpointInterval", "checkpoint interval (>= 1)", None),
- ("seed", "random seed", None),
+ ("seed", "random seed", "random.randint(0, sys.maxsize)"),
--- End diff --
So the original bug mentioned that in Scala it was done randomly. I think
for testing using a fixed seed in the constructor is a good way to ensure
reproduceability. I'm fine with replacing this with a hash of the class or
something if we think that would be better, but I think it probably makes sense
to do the same thing between Python & Scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
