bjornjorgensen commented on code in PR #36461:
URL: https://github.com/apache/spark/pull/36461#discussion_r866649565
##########
connector/avro/src/main/java/org/apache/spark/sql/avro/SparkAvroKeyOutputFormat.java:
##########
@@ -46,6 +46,7 @@ static class SparkRecordWriterFactory extends
RecordWriterFactory<GenericRecord>
this.metadata = metadata;
}
+ @Override
Review Comment:
OK found the same with sonarqube
##########
common/network-common/src/main/java/org/apache/spark/network/util/NettyLogger.java:
##########
@@ -35,6 +35,7 @@ private static class NoContentLoggingHandler extends
LoggingHandler {
super(clazz, level);
}
+ @Override
Review Comment:
OK found the same with sonarqube
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractLauncher.java:
##########
@@ -298,6 +298,7 @@ protected boolean handleUnknown(String opt) {
return true;
}
+ @Override
Review Comment:
OK found the same with sonarqube
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/AlwaysTrue.java:
##########
@@ -34,13 +34,16 @@ public AlwaysTrue() {
super("ALWAYS_TRUE", new Predicate[]{});
}
+ @Override
public Boolean value() {
return true;
}
+ @Override
public DataType dataType() {
return DataTypes.BooleanType;
}
+ @Override
Review Comment:
OK found the same with sonarqube
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/AlwaysFalse.java:
##########
@@ -34,13 +34,16 @@ public AlwaysFalse() {
super("ALWAYS_FALSE", new Predicate[]{});
}
+ @Override
public Boolean value() {
return false;
}
+ @Override
public DataType dataType() {
return DataTypes.BooleanType;
}
+ @Override
Review Comment:
OK found the same with sonarqube
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
