srowen commented on code in PR #36457:
URL: https://github.com/apache/spark/pull/36457#discussion_r866766828
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala:
##########
@@ -642,7 +642,7 @@ case class RegExpReplace(subject: Expression, regexp:
Expression, rep: Expressio
}
val source = s.toString()
val position = i.asInstanceOf[Int] - 1
- if (position < source.length) {
+ if (position < source.length || (position == 0 && source.equals(""))) {
Review Comment:
Hm, how doesn't it catch the empty string? in that case, adding `position ==
0 ||` makes the check true iff the string is empty (`position < source.length`
is `false`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
