cloud-fan commented on code in PR #36265:
URL: https://github.com/apache/spark/pull/36265#discussion_r866859656


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2563,7 +2563,23 @@ class Analyzer(override val catalogManager: 
CatalogManager)
 
       case Sort(sortOrder, global, agg: Aggregate) if agg.resolved =>
         // We should resolve the references normally based on child 
(agg.output) first.
-        val maybeResolved = 
sortOrder.map(_.child).map(resolveExpressionByPlanOutput(_, agg))

Review Comment:
   My proposal is: we still try to resolve the column to `agg.output` first, 
but temporarily (use `TempResolvedColumn`). If the order by expression is 
resolved but contains aggregate functions, unresolve the column and call 
`resolveOperatorWithAggregate`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to