ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r867302077
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala: ########## @@ -48,6 +48,8 @@ case class If(predicate: Expression, trueValue: Expression, falseValue: Expressi override def second: Expression = trueValue override def third: Expression = falseValue override def nullable: Boolean = trueValue.nullable || falseValue.nullable + override def foldable: Boolean = children.forall(_.foldable) Review Comment: +1, pull out to `ConditionalExpressions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
