LuciferYang commented on code in PR #36467:
URL: https://github.com/apache/spark/pull/36467#discussion_r867596466
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/RocksDB.java:
##########
@@ -457,4 +480,19 @@ byte[] getPrefix(RocksDBTypeInfo.Index idx) throws
Exception {
}
+ private static class RocksDBIteratorWeakReference extends
WeakReference<RocksDBIterator<?>> {
Review Comment:
`RocksDBIteratorWeakReference` use to hold `RocksIterator`, better as the
inner class of `RocksDB` or `RocksDBIterator`? I want your suggestion
@dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
