xinrong-databricks commented on code in PR #36414:
URL: https://github.com/apache/spark/pull/36414#discussion_r868482037
##########
python/pyspark/pandas/generic.py:
##########
@@ -1312,11 +1326,20 @@ def sum(psser: "Series") -> Column:
return F.coalesce(F.sum(spark_column), SF.lit(0))
return self._reduce_for_stat_function(
- sum, name="sum", axis=axis, numeric_only=numeric_only,
min_count=min_count
+ sum,
+ name="sum",
+ axis=axis,
+ numeric_only=numeric_only,
+ min_count=min_count,
+ skipna=skipna,
)
def product(
- self, axis: Optional[Axis] = None, numeric_only: bool = None,
min_count: int = 0
+ self,
+ axis: Optional[Axis] = None,
+ skipna: bool = True,
Review Comment:
Agree! I will use `..verionchanged` as a mark to remind us of mentioning it
in the migration guide from 3.3 to 3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
