cloud-fan commented on code in PR #36495:
URL: https://github.com/apache/spark/pull/36495#discussion_r869132330


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTable.scala:
##########
@@ -40,6 +40,8 @@ case class JDBCTable(ident: Identifier, schema: StructType, 
jdbcOptions: JDBCOpt
     util.EnumSet.of(BATCH_READ, V1_BATCH_WRITE, TRUNCATE)
   }
 
+  override def properties(): util.Map[String, String] = 
jdbcOptions.parameters.toMap.asJava

Review Comment:
   we need to define what are the table properties of a JDBC table. Ideally it 
should only be the properties users put in  `CREATE TABLE ... TBLPROPERTIES`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to