cloud-fan commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869781957
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String],
isNamespace: Boolean)
override def output: Seq[Attribute] = Nil
}
+/**
+ * A resolved leaf like node that its statistics is no meaning.
+ */
+trait LeafNodeWithoutStats extends LogicalPlan with LeafLike[LogicalPlan] {
Review Comment:
Can we make it an abstract class and extends `LeafNode`? I'm a bit worried
about changing the class hierarchy unnecessarily in this PR.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String],
isNamespace: Boolean)
override def output: Seq[Attribute] = Nil
}
+/**
+ * A resolved leaf like node that its statistics is no meaning.
Review Comment:
```suggestion
* A resolved leaf like node that its statistics has no meaning.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
