cloud-fan commented on code in PR #36418:
URL: https://github.com/apache/spark/pull/36418#discussion_r870206196
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/Catalogs.scala:
##########
@@ -45,7 +45,11 @@ private[sql] object Catalogs {
@throws[SparkException]
def load(name: String, conf: SQLConf): CatalogPlugin = {
val pluginClassName = try {
- conf.getConfString("spark.sql.catalog." + name)
+ val _pluginClassName = conf.getConfString(s"spark.sql.catalog.$name")
+ if (name.contains(".")) {
Review Comment:
I see. Let's get conf first then, and also add some comments to explain the
rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
