HyukjinKwon commented on code in PR #36507:
URL: https://github.com/apache/spark/pull/36507#discussion_r870342302
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -318,7 +318,7 @@ class JDBCSuite extends QueryTest
}
test("SELECT *") {
- assert(sql("SELECT * FROM foobar").collect().size === 3)
+ assert(sql("SELECT * FROM foobar").count() === 3)
Review Comment:
@morvenhuang Just to clarify, the whole `collect().size` vs `count()` at
`DataFrame` is completely different. For example, this will prune all, and
won't actually test if the data in foobar is correctly ser/de or not.
We should better revert the changes here. Or you might have to justify that
each fix here does not change the test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
