HyukjinKwon commented on code in PR #36504:
URL: https://github.com/apache/spark/pull/36504#discussion_r870852807
##########
python/pyspark/sql/types.py:
##########
@@ -1958,27 +1958,25 @@ def can_convert(self, obj: Any) -> bool:
and is_timestamp_ntz_preferred()
)
- def convert(self, obj: datetime.datetime, gateway_client: JavaGateway) ->
JavaObject:
- from pyspark import SparkContext
-
+ def convert(self, obj: datetime.datetime, gateway_client: GatewayClient)
-> JavaObject:
seconds = calendar.timegm(obj.utctimetuple())
- jvm = SparkContext._jvm
- assert jvm is not None
- return
jvm.org.apache.spark.sql.catalyst.util.DateTimeUtils.microsToLocalDateTime(
- int(seconds) * 1000000 + obj.microsecond
+ DateTimeUtils = JavaClass(
+ "org.apache.spark.sql.catalyst.util.DateTimeUtils",
+ gateway_client,
)
+ return DateTimeUtils.microsToLocalDateTime(int(seconds) * 1000000 +
obj.microsecond)
class DayTimeIntervalTypeConverter:
def can_convert(self, obj: Any) -> bool:
return isinstance(obj, datetime.timedelta)
- def convert(self, obj: datetime.timedelta, gateway_client: JavaGateway) ->
JavaObject:
- from pyspark import SparkContext
-
- jvm = SparkContext._jvm
- assert jvm is not None
- return
jvm.org.apache.spark.sql.catalyst.util.IntervalUtils.microsToDuration(
+ def convert(self, obj: datetime.timedelta, gateway_client: GatewayClient)
-> JavaObject:
+ IntervalUtils = JavaClass(
Review Comment:
Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
