[GitHub] [spark] gengliangwang commented on a diff in pull request #36525: [SPARK-39166] Provide runtime error query context for binary arithmetic when WSCG is off

[GitBox]

gengliangwang commented on code in PR #36525:
URL: https://github.com/apache/spark/pull/36525#discussion_r871524691


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -381,9 +389,11 @@ case class Subtract(
     case _: YearMonthIntervalType =>
       MathUtils.subtractExact(input1.asInstanceOf[Int], 
input2.asInstanceOf[Int])
     case _: IntegerType if failOnError =>
-      MathUtils.subtractExact(input1.asInstanceOf[Int], 
input2.asInstanceOf[Int], origin.context)
+      MathUtils.subtractExact(input1.asInstanceOf[Int], 
input2.asInstanceOf[Int],
+        queryContext)
     case _: LongType if failOnError =>
-      MathUtils.subtractExact(input1.asInstanceOf[Long], 
input2.asInstanceOf[Long], origin.context)
+      MathUtils.subtractExact(input1.asInstanceOf[Long], 
input2.asInstanceOf[Long],
+        queryContext)

Review Comment:
   ```suggestion
         MathUtils.subtractExact(input1.asInstanceOf[Long], 
input2.asInstanceOf[Long], queryContext)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org