srielau commented on PR #36151: URL: https://github.com/apache/spark/pull/36151#issuecomment-1125216782
> > I think this this is worrysome for two reasons > > ``` > > 1. It adds confusion between what is a string and what is an identifier. > > > > 2. It singles out a specific kind of an identifier (column) and a specific narrow kind of context (column aliasing in the select list). > > ``` > > > > > > > > > > > > > > > > > > > > > > > > I'm totally for a switch that sets whether double quotes are used for identifiers or strings. but it should be: > > ``` > > 1. Pick one > > > > 2. Holistic > > ``` > > My original PR was to change the meaning of double quotes to be identifiers instead of strings but the [feedback](https://github.com/apache/spark/pull/35853#issuecomment-1093676903) was that it was too late to make a change this large. However, maybe we can introduce a configuration option to determine how this is handled, as suggested [here](https://github.com/apache/spark/pull/35853#issuecomment-1095156190). I think a config would be appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
