gengliangwang commented on code in PR #36445:
URL: https://github.com/apache/spark/pull/36445#discussion_r871614908
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala:
##########
@@ -1510,6 +1510,151 @@ class PlanResolutionSuite extends AnalysisTest {
case other => fail("Expect MergeIntoTable, but got:\n" +
other.treeString)
}
+
+ // DEFAULT columns (implicit):
+ // All cases of the $target table lack any explicitly-defined DEFAULT
columns. Therefore any
+ // DEFAULT column references in the below MERGE INTO command should
resolve to literal NULL.
+ // This test case covers that behavior.
+ val sql6 =
+ s"""
+ |MERGE INTO $target AS target
+ |USING $source AS source
+ |ON target.i = source.i
+ |WHEN MATCHED AND (target.s='delete') THEN DELETE
+ |WHEN MATCHED AND (target.s='update')
+ |THEN UPDATE SET target.s = DEFAULT, target.i = target.i
+ |WHEN NOT MATCHED AND (source.s='insert')
+ | THEN INSERT (target.i, target.s) values (DEFAULT, DEFAULT)
+ """.stripMargin
+ parseAndResolve(sql6) match {
+ case m: MergeIntoTable =>
+ val source = m.sourceTable
+ val target = m.targetTable
+ val ti = target.output.find(_.name ==
"i").get.asInstanceOf[AttributeReference]
+ val si = source.output.find(_.name ==
"i").get.asInstanceOf[AttributeReference]
+ m.mergeCondition match {
+ case EqualTo(l: AttributeReference, r: AttributeReference) =>
+ assert(l.sameRef(ti) && r.sameRef(si))
+ case Literal(_, BooleanType) => // this is acceptable as a merge
condition
+ case other => fail("unexpected merge condition " + other)
+ }
+ assert(m.matchedActions.length == 2)
+ val first = m.matchedActions(0)
+ first match {
+ case DeleteAction(Some(EqualTo(_: AttributeReference,
StringLiteral("delete")))) =>
+ case other => fail("unexpected first matched action " + other)
+ }
+ val second = m.matchedActions(1)
+ second match {
+ case UpdateAction(Some(EqualTo(_: AttributeReference,
StringLiteral("update"))),
+ Seq(
+ Assignment(_: AttributeReference, AnsiCast(Literal(null, _),
StringType, _)),
+ Assignment(_: AttributeReference, _: AttributeReference))) =>
+ case other => fail("unexpected second matched action " + other)
+ }
+ assert(m.notMatchedActions.length == 1)
+ val negative = m.notMatchedActions(0)
+ negative match {
+ case InsertAction(Some(EqualTo(_: AttributeReference,
StringLiteral("insert"))),
+ Seq(Assignment(i: AttributeReference, AnsiCast(Literal(null, _),
IntegerType, _)),
+ Assignment(s: AttributeReference, AnsiCast(Literal(null, _),
StringType, _)))) =>
+ assert(i.name == "i")
+ assert(s.name == "s")
+ case other => fail("unexpected not matched action " + other)
+ }
+
+ case other =>
+ fail("Expect MergeIntoTable, but got:\n" + other.treeString)
+ }
+
+ // DEFAULT column reference in the merge condition:
+ // This MERGE INTO command includes an ON clause with a DEFAULT column
reference. This is
+ // invalid and returns an error message.
+ val mergeWithDefaultReferenceInMergeCondition =
+ s"""
Review Comment:
nit: indent
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala:
##########
@@ -1510,6 +1510,151 @@ class PlanResolutionSuite extends AnalysisTest {
case other => fail("Expect MergeIntoTable, but got:\n" +
other.treeString)
}
+
+ // DEFAULT columns (implicit):
+ // All cases of the $target table lack any explicitly-defined DEFAULT
columns. Therefore any
+ // DEFAULT column references in the below MERGE INTO command should
resolve to literal NULL.
+ // This test case covers that behavior.
+ val sql6 =
+ s"""
+ |MERGE INTO $target AS target
+ |USING $source AS source
+ |ON target.i = source.i
+ |WHEN MATCHED AND (target.s='delete') THEN DELETE
+ |WHEN MATCHED AND (target.s='update')
+ |THEN UPDATE SET target.s = DEFAULT, target.i = target.i
+ |WHEN NOT MATCHED AND (source.s='insert')
+ | THEN INSERT (target.i, target.s) values (DEFAULT, DEFAULT)
+ """.stripMargin
+ parseAndResolve(sql6) match {
+ case m: MergeIntoTable =>
+ val source = m.sourceTable
+ val target = m.targetTable
+ val ti = target.output.find(_.name ==
"i").get.asInstanceOf[AttributeReference]
+ val si = source.output.find(_.name ==
"i").get.asInstanceOf[AttributeReference]
+ m.mergeCondition match {
+ case EqualTo(l: AttributeReference, r: AttributeReference) =>
+ assert(l.sameRef(ti) && r.sameRef(si))
+ case Literal(_, BooleanType) => // this is acceptable as a merge
condition
+ case other => fail("unexpected merge condition " + other)
+ }
+ assert(m.matchedActions.length == 2)
+ val first = m.matchedActions(0)
+ first match {
+ case DeleteAction(Some(EqualTo(_: AttributeReference,
StringLiteral("delete")))) =>
+ case other => fail("unexpected first matched action " + other)
+ }
+ val second = m.matchedActions(1)
+ second match {
+ case UpdateAction(Some(EqualTo(_: AttributeReference,
StringLiteral("update"))),
+ Seq(
+ Assignment(_: AttributeReference, AnsiCast(Literal(null, _),
StringType, _)),
+ Assignment(_: AttributeReference, _: AttributeReference))) =>
+ case other => fail("unexpected second matched action " + other)
+ }
+ assert(m.notMatchedActions.length == 1)
+ val negative = m.notMatchedActions(0)
+ negative match {
+ case InsertAction(Some(EqualTo(_: AttributeReference,
StringLiteral("insert"))),
+ Seq(Assignment(i: AttributeReference, AnsiCast(Literal(null, _),
IntegerType, _)),
+ Assignment(s: AttributeReference, AnsiCast(Literal(null, _),
StringType, _)))) =>
+ assert(i.name == "i")
+ assert(s.name == "s")
+ case other => fail("unexpected not matched action " + other)
+ }
+
+ case other =>
+ fail("Expect MergeIntoTable, but got:\n" + other.treeString)
+ }
+
+ // DEFAULT column reference in the merge condition:
+ // This MERGE INTO command includes an ON clause with a DEFAULT column
reference. This is
+ // invalid and returns an error message.
+ val mergeWithDefaultReferenceInMergeCondition =
+ s"""
+ |MERGE INTO testcat.tab AS target
+ |USING testcat.tab1 AS source
+ |ON target.i = DEFAULT
+ |WHEN MATCHED AND (target.s = 31) THEN DELETE
+ |WHEN MATCHED AND (target.s = 31)
+ | THEN UPDATE SET target.s = DEFAULT
+ |WHEN NOT MATCHED AND (source.s='insert')
+ | THEN INSERT (target.i, target.s) values (DEFAULT, DEFAULT)
+ """.stripMargin
+ assert(intercept[AnalysisException] {
+ parseAndResolve(mergeWithDefaultReferenceInMergeCondition)
+ }.getMessage.contains(
+
QueryCompilationErrors.defaultReferencesNotAllowedInMergeCondition().getMessage))
+
+ // DEFAULT column reference within a complex expression:
+ // This MERGE INTO command includes a WHEN MATCHED clause with a
DEFAULT column reference as
+ // of a complex expression (DEFAULT + 1). This is invalid and returns
an error message.
+ val mergeWithDefaultReferenceAsPartOfComplexExpression =
+ s"""
Review Comment:
nit: indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
