Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5843#discussion_r30366233
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -36,6 +37,35 @@ private[ui] class StagePage(parent: StagesTab) extends 
WebUIPage("stage") {
       private val progressListener = parent.progressListener
       private val operationGraphListener = parent.operationGraphListener
     
    +  private val TIMELINE_LEGEND = {
    +    <div class="legend-area">
    +      <svg>
    +        {
    +          val legendPairs = List(("deserialization-time-proportion", "Task 
Deserialization Time"),
    +            ("shuffle-read-time-proportion", "Shuffle Read Time"),
    +            ("executor-runtime-proportion", "Executor Computing Time"),
    +            ("shuffle-write-time-proportion", "Shuffle Write Time"),
    +            ("serialization-time-proportion", "Result Serialization TIme"),
    +            ("getting-result-time-proportion", "Getting Result Time"),
    +            ("scheduler-delay-proportion", "Scheduler Delay"))
    --- End diff --
    
    one last nit: Can you move scheduler delay to be first, to reflect the 
order that it's shown in the visualization?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to