cloud-fan commented on code in PR #36521:
URL: https://github.com/apache/spark/pull/36521#discussion_r872152940
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -240,8 +240,31 @@ abstract class JdbcDialect extends Serializable with
Logging{
getJDBCType(dataType).map(_.databaseTypeDefinition).getOrElse(dataType.typeName)
s"CAST($l AS $databaseTypeDefinition)"
}
+
+ override def visitSQLFunction(funcName: String, inputs: Array[String]):
String = {
+ if (isSupportedFunction(funcName)) {
+ s"""$funcName(${inputs.mkString(", ")})"""
+ } else {
+ throw QueryCompilationErrors.noSuchFunctionError(dialectName, funcName)
+ }
+ }
}
+ /**
+ * Returns whether the database supports function.
+ * @param funcName Function name
+ * @return True if the database supports function.
+ */
+ @Since("3.3.0")
+ def isSupportedFunction(funcName: String): Boolean = false
+
+ /**
+ * Returns the name of database dialect.
+ * @return
+ */
+ @Since("3.3.0")
+ def dialectName: String = this.getClass.getCanonicalName
Review Comment:
Do we really need an API for this? I think the caller side can just write
`dialect.getClass.getSimpleName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
