yaooqinn commented on code in PR #36497:
URL: https://github.com/apache/spark/pull/36497#discussion_r872184124
##########
sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala:
##########
@@ -47,15 +47,17 @@ class MiscFunctionsSuite extends QueryTest with
SharedSparkSession {
test("SPARK-21957: get current_user in normal spark apps") {
val user = spark.sparkContext.sparkUser
withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
- val df = sql("select current_user(), current_user")
- checkAnswer(df, Row(user, user))
+ val df = sql("select current_user(), current_user, user, user()")
+ checkAnswer(df, Row(user, user, user, user))
}
withSQLConf(SQLConf.ANSI_ENABLED.key -> "true",
SQLConf.ENFORCE_RESERVED_KEYWORDS.key -> "true") {
- val df = sql("select current_user")
- checkAnswer(df, Row(spark.sparkContext.sparkUser))
- val e = intercept[ParseException](sql("select current_user()"))
- assert(e.getMessage.contains("current_user"))
+ val df = sql("select current_user, user")
Review Comment:
we are not testing errors with this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
