cloud-fan commented on code in PR #36541:
URL: https://github.com/apache/spark/pull/36541#discussion_r873423506
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1303,12 +1303,25 @@ case class LocalLimit(limitExpr: Expression, child:
LogicalPlan) extends OrderPr
copy(child = newChild)
}
+object OffsetAndLimit {
+ def unapply(p: GlobalLimit): Option[(Int, Int, LogicalPlan)] = {
+ p match {
+ // Optimizer pushes local limit through offset, so we need to match the
plan this way.
+ case GlobalLimit(IntegerLiteral(globalLimit),
+ Offset(IntegerLiteral(offset),
+ LocalLimit(IntegerLiteral(localLimit), child)))
+ if globalLimit + offset == localLimit =>
+ Some((offset, globalLimit, child))
Review Comment:
This pattern match is to match a logical offset + limit, but we care more
about semantics here. Returning `localLimit` is super confusing.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1303,12 +1303,25 @@ case class LocalLimit(limitExpr: Expression, child:
LogicalPlan) extends OrderPr
copy(child = newChild)
}
+object OffsetAndLimit {
+ def unapply(p: GlobalLimit): Option[(Int, Int, LogicalPlan)] = {
+ p match {
+ // Optimizer pushes local limit through offset, so we need to match the
plan this way.
+ case GlobalLimit(IntegerLiteral(globalLimit),
+ Offset(IntegerLiteral(offset),
+ LocalLimit(IntegerLiteral(localLimit), child)))
+ if globalLimit + offset == localLimit =>
+ Some((offset, globalLimit, child))
Review Comment:
This pattern match is to match a logical offset + limit, and we care more
about semantics here. Returning `localLimit` is super confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
