beliefer commented on code in PR #36295:
URL: https://github.com/apache/spark/pull/36295#discussion_r873554764
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala:
##########
@@ -419,6 +420,30 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper wit
}
}
+ private def pushDownOffset(plan: LogicalPlan, offset: Int): (LogicalPlan,
Boolean) = plan match {
+ case operation @ ScanOperation(_, filter, sHolder: ScanBuilderHolder) if
filter.isEmpty =>
+ val isPushed = PushDownUtils.pushOffset(sHolder.builder, offset)
+ if (isPushed) {
+ sHolder.pushedOffset = Some(offset)
+ }
+ (operation, isPushed)
+ case p: Project =>
+ val (newChild, isPushed) = pushDownOffset(p.child, offset)
+ (p.withNewChildren(Seq(newChild)), isPushed)
+ case other => (other, false)
+ }
+
+ def pushDownOffsets(plan: LogicalPlan): LogicalPlan = plan.transform {
+ // TODO supports push down Limit append Offset or Offset append Limit
+ case offset @ Offset(IntegerLiteral(n), child) =>
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
