HyukjinKwon commented on code in PR #36576:
URL: https://github.com/apache/spark/pull/36576#discussion_r874632251
##########
sql/core/src/test/scala/org/apache/spark/sql/BloomFilterAggregateQuerySuite.scala:
##########
@@ -35,23 +34,26 @@ class BloomFilterAggregateQuerySuite extends QueryTest with
SharedSparkSession {
val funcId_bloom_filter_agg = new FunctionIdentifier("bloom_filter_agg")
val funcId_might_contain = new FunctionIdentifier("might_contain")
- // Register 'bloom_filter_agg' to builtin.
- FunctionRegistry.builtin.registerFunction(funcId_bloom_filter_agg,
Review Comment:
I think Scala version or something else caused the test failure by the
difference class reference order (vs. CI) during running tests:
1. `BloomFilterAggregateQuerySuite` gets referred first somehow/somewhere
2. These functions get registered first (because these previous codes will
be executed when `BloomFilterAggregateQuerySuite` is referred).
3. Other tests run before `BloomFilterAggregateQuerySuite` actually runs
(and deregisters these functions at `afterAll`.
4. Other tests fail because of two functions added by
`BloomFilterAggregateQuerySuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
