wypoon commented on code in PR #36585:
URL: https://github.com/apache/spark/pull/36585#discussion_r875380133
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -369,13 +369,11 @@ object QueryParsingErrors extends QueryErrorsBase {
new ParseException(errorClass = "DUPLICATE_KEY", messageParameters =
Array(toSQLId(key)), ctx)
}
- def unexpectedFomatForSetConfigurationError(ctx: ParserRuleContext):
Throwable = {
+ def unexpectedFormatForSetConfigurationError(ctx: ParserRuleContext):
Throwable = {
new ParseException(
- s"""
- |Expected format is 'SET', 'SET key', or 'SET key=value'. If you want
to include
+ s"""Expected format is 'SET', 'SET key', or 'SET key=value'. If you want
to include
Review Comment:
The `s` in `s"""` is not needed, as you point out. I believe the original
author used `replaceAll` to avoid line breaks and make the message a single
line.
Sure, I can change to using simple concatenation of two strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
