dongjoon-hyun commented on code in PR #36597:
URL: https://github.com/apache/spark/pull/36597#discussion_r876221706
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -494,6 +495,19 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
}
}
.flatMap { entry => EventLogFileReader(fs, entry) }
+ .filter { reader =>
+ try {
+ reader.modificationTime
+ true
+ } catch {
+ case e: Exception =>
+ logError("Exception in getting modificationTime of " +
reader.rootPath.getName + ".")
+ false
+ }
+ }
+ .sortWith { case (entry1, entry2) =>
+ entry1.modificationTime > entry2.modificationTime
Review Comment:
This looks orthogonal to `BatchSize` feature. I'd like to recommend you to
spin off this `sorting` contribution into another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
