cloud-fan commented on code in PR #36593:
URL: https://github.com/apache/spark/pull/36593#discussion_r877115137
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala:
##########
@@ -744,6 +744,14 @@ object DataSourceStrategy
PushableColumnWithoutNestedColumn(right), _) =>
Some(new GeneralAggregateFunc("CORR", agg.isDistinct,
Array(FieldReference.column(left), FieldReference.column(right))))
+ case aggregate.V2Aggregator(aggrFunc, children, _, _) =>
+ val translatedExprs = children.flatMap(PushableExpression.unapply(_))
+ if (translatedExprs.length == children.length) {
+ Some(new
GeneralAggregateFunc(aggrFunc.name().toUpperCase(Locale.ROOT), agg.isDistinct,
Review Comment:
ditto, let' create a dedicated v2 api, such as `UserDefinedAggregateFunction`
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala:
##########
@@ -744,6 +744,14 @@ object DataSourceStrategy
PushableColumnWithoutNestedColumn(right), _) =>
Some(new GeneralAggregateFunc("CORR", agg.isDistinct,
Array(FieldReference.column(left), FieldReference.column(right))))
+ case aggregate.V2Aggregator(aggrFunc, children, _, _) =>
+ val translatedExprs = children.flatMap(PushableExpression.unapply(_))
+ if (translatedExprs.length == children.length) {
+ Some(new
GeneralAggregateFunc(aggrFunc.name().toUpperCase(Locale.ROOT), agg.isDistinct,
Review Comment:
ditto, let's create a dedicated v2 api, such as
`UserDefinedAggregateFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
