Yikun commented on code in PR #36599:
URL: https://github.com/apache/spark/pull/36599#discussion_r877673383
##########
python/pyspark/pandas/series.py:
##########
@@ -6239,13 +6239,19 @@ def argsort(self) -> "Series":
ps.concat([psser, self.loc[self.isnull()].spark.transform(lambda
_: SF.lit(-1))]),
)
- def argmax(self) -> int:
+ def argmax(self, skipna: bool = True) -> int:
Review Comment:
And the upstream pandas's `axis` is also a dummy parameter (this is really
special). So we just keep same with pandas doc/parameters is enough. After
this, the missing parameters would be remove is right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
