Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6088#discussion_r30377473
--- Diff: python/pyspark/ml/pipeline.py ---
@@ -54,18 +76,34 @@ class Transformer(Params):
__metaclass__ = ABCMeta
@abstractmethod
- def transform(self, dataset, params={}):
+ def _transform(self, dataset):
"""
Transforms the input dataset with optional parameters.
:param dataset: input dataset, which is an instance of
:py:class:`pyspark.sql.DataFrame`
- :param params: an optional param map that overwrites embedded
- params
:returns: transformed dataset
"""
raise NotImplementedError()
+ def transform(self, dataset, params={}):
+ """
+ Transforms the input dataset with optional parameters.
+
+ :param dataset: input dataset, which is an instance of
+ :py:class:`pyspark.sql.DataFrame`
+ :param params: an optional param map that overrides embedded
+ params.
+ :returns: transformed dataset
+ """
+ if isinstance(params, dict):
--- End diff --
Are you adding support for list/tuple later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
