MaxGekk commented on code in PR #36617:
URL: https://github.com/apache/spark/pull/36617#discussion_r878905727
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala:
##########
@@ -583,6 +583,66 @@ class QueryCompilationErrorsSuite
msg = "The deserializer is not supported: try to map \"STRUCT<a: STRING,
b: INT>\" " +
"to Tuple1, but failed as the number of fields does not line up.")
}
+
+ test("UNSUPPORTED_GENERATOR: " +
+ "generators are not supported when it's nested in expressions") {
+ val e = intercept[AnalysisException](
+ sql("""select explode(Array(1, 2, 3)) + 1""").collect()
+ )
+
+ checkErrorClass(
+ exception = e,
+ errorClass = "UNSUPPORTED_GENERATOR",
+ errorSubClass = Some("NESTED_IN_EXPRESSIONS"),
+ msg = "The generator is not supported: nested in expressions
(explode(array(1, 2, 3)) + 1)")
Review Comment:
Please, quote (explode(array(1, 2, 3)) + 1) by default (double quotes).
Maybe, it is better to add a helper method `toSQLExpr()` to QueryErrorsBase
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala:
##########
@@ -583,6 +583,66 @@ class QueryCompilationErrorsSuite
msg = "The deserializer is not supported: try to map \"STRUCT<a: STRING,
b: INT>\" " +
"to Tuple1, but failed as the number of fields does not line up.")
}
+
+ test("UNSUPPORTED_GENERATOR: " +
+ "generators are not supported when it's nested in expressions") {
+ val e = intercept[AnalysisException](
+ sql("""select explode(Array(1, 2, 3)) + 1""").collect()
+ )
+
+ checkErrorClass(
+ exception = e,
+ errorClass = "UNSUPPORTED_GENERATOR",
+ errorSubClass = Some("NESTED_IN_EXPRESSIONS"),
+ msg = "The generator is not supported: nested in expressions
(explode(array(1, 2, 3)) + 1)")
+ }
+
+ test("UNSUPPORTED_GENERATOR: only one generator allowed") {
+ val e = intercept[AnalysisException](
+ sql("""select explode(Array(1, 2, 3)), explode(Array(1, 2,
3))""").collect()
+ )
+
+ checkErrorClass(
+ exception = e,
+ errorClass = "UNSUPPORTED_GENERATOR",
+ errorSubClass = Some("MULTI_GENERATOR"),
+ msg = "The generator is not supported: only one generator allowed per
select clause " +
+ "but found 2: explode(array(1, 2, 3)), explode(array(1, 2, 3))"
Review Comment:
Let quote expressions:
explode(array(1, 2, 3)), explode(array(1, 2, 3)) -> "explode(array(1, 2,
3))", "explode(array(1, 2, 3))"
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala:
##########
@@ -583,6 +583,66 @@ class QueryCompilationErrorsSuite
msg = "The deserializer is not supported: try to map \"STRUCT<a: STRING,
b: INT>\" " +
"to Tuple1, but failed as the number of fields does not line up.")
}
+
+ test("UNSUPPORTED_GENERATOR: " +
+ "generators are not supported when it's nested in expressions") {
+ val e = intercept[AnalysisException](
+ sql("""select explode(Array(1, 2, 3)) + 1""").collect()
+ )
+
+ checkErrorClass(
+ exception = e,
+ errorClass = "UNSUPPORTED_GENERATOR",
+ errorSubClass = Some("NESTED_IN_EXPRESSIONS"),
+ msg = "The generator is not supported: nested in expressions
(explode(array(1, 2, 3)) + 1)")
+ }
+
+ test("UNSUPPORTED_GENERATOR: only one generator allowed") {
+ val e = intercept[AnalysisException](
+ sql("""select explode(Array(1, 2, 3)), explode(Array(1, 2,
3))""").collect()
+ )
+
+ checkErrorClass(
+ exception = e,
+ errorClass = "UNSUPPORTED_GENERATOR",
+ errorSubClass = Some("MULTI_GENERATOR"),
+ msg = "The generator is not supported: only one generator allowed per
select clause " +
+ "but found 2: explode(array(1, 2, 3)), explode(array(1, 2, 3))"
+ )
+ }
+
+ test("UNSUPPORTED_GENERATOR: generators are not supported outside the SELECT
clause") {
+ val e = intercept[AnalysisException](
+ sql("""select 1 from t order by explode(Array(1, 2, 3))""").collect()
+ )
+
+ checkErrorClass(
+ exception = e,
+ errorClass = "UNSUPPORTED_GENERATOR",
+ errorSubClass = Some("OUTSIDE_SELECT"),
+ msg = "The generator is not supported: outside the SELECT clause, found:
" +
+ "'Sort [explode(array(1, 2, 3)) ASC NULLS FIRST], true"
+ )
+ }
+
+ test("UNSUPPORTED_GENERATOR: not a generator") {
+ val e = intercept[AnalysisException](
+ sql(
+ """
+ |SELECT explodedvalue.*
+ |FROM VALUES array(1, 2, 3) AS (value)
+ |LATERAL VIEW array_contains(value, 1) AS
explodedvalue""".stripMargin).collect()
+ )
+
+ checkErrorClass(
+ exception = e,
+ errorClass = "UNSUPPORTED_GENERATOR",
+ errorSubClass = Some("NOT_GENERATOR"),
+ msg = "The generator is not supported: array_contains is expected to be
a generator. " +
Review Comment:
Please, quite array_contains as SQL Id: `array_contains`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
