cloud-fan commented on code in PR #36503:
URL: https://github.com/apache/spark/pull/36503#discussion_r879972900


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -752,9 +752,30 @@ trait CheckAnalysis extends PredicateHelper with 
LookupCatalog {
       expressions.exists(_.exists(_.semanticEquals(expr)))
     }
 
+    def checkOuterReferenceUtil(attrs: Seq[Attribute], outer: OuterReference): 
Unit = {
+      if (!attrs.exists(_.exprId == outer.exprId)) {
+        failAnalysis("outer attribute not found")
+      }
+    }
+
+    def checkOuterReference(p: LogicalPlan, expr: SubqueryExpression): Unit = 
p match {
+      case f: Filter =>

Review Comment:
   why do we only apply the check for Filter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to