cloud-fan commented on code in PR #36649:
URL: https://github.com/apache/spark/pull/36649#discussion_r880677944
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -816,6 +818,15 @@ class JDBCSuite extends QueryTest
}
}
+ test("register dialect specific functions") {
Review Comment:
This test does not reflect the expectation. The user story should be: if an
end-user registers a JDBC catalog with a certain dialect, he/she can directly
call functions like `SELECT myCatalog.database.funcName(...)` if the function
is registered by the dialect.
The workflow should be
1. JDBC dialect report the functions it supports
2. Spark (JDBCTableCatalog) registers these function
3. end-users call these functions in their queries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
