LuciferYang commented on code in PR #36616:
URL: https://github.com/apache/spark/pull/36616#discussion_r881376284
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java:
##########
@@ -42,6 +43,27 @@ public static OnHeapColumnVector[] allocateColumns(int
capacity, StructType sche
return allocateColumns(capacity, schema.fields());
}
+ /**
+ * Allocates columns to store elements of each field of the schema,
+ * the constant column use `ConstantColumnVector` and others use
`OnHeapColumnVector`,
+ * this method assumes that all constant column are at the end of schema.
+ * Capacity is the initial capacity of the vector and it will grow as
necessary. Capacity is
+ * in number of elements, not number of bytes.
+ */
+ public static ColumnVector[] allocateColumns(
Review Comment:
[34b3b64](https://github.com/apache/spark/pull/36616/commits/34b3b64e368cddca89dcc3b5f81737aaec63be40)
Move to ColumnVectorUtils and merge them into one
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java:
##########
@@ -42,6 +43,27 @@ public static OnHeapColumnVector[] allocateColumns(int
capacity, StructType sche
return allocateColumns(capacity, schema.fields());
}
+ /**
+ * Allocates columns to store elements of each field of the schema,
+ * the constant column use `ConstantColumnVector` and others use
`OnHeapColumnVector`,
+ * this method assumes that all constant column are at the end of schema.
+ * Capacity is the initial capacity of the vector and it will grow as
necessary. Capacity is
+ * in number of elements, not number of bytes.
+ */
+ public static ColumnVector[] allocateColumns(
Review Comment:
[34b3b64](https://github.com/apache/spark/pull/36616/commits/34b3b64e368cddca89dcc3b5f81737aaec63be40)
Move to ColumnVectorUtils and merge them into one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
